DevKit7/citro3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Addressing feedback:

Browse Source 
mtheall: The FVec3_New is redundant.
This commit is contained in:
Thompson Lee 2016-08-04 10:04:11 -04:00
parent 930442b94f
commit 49403de54d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/maths/mtx_lookat.c
View File

@ -8,7 +8,10 @@ void Mtx_LookAt(C3D_Mtx* out, C3D_FVec cameraPosition, C3D_FVec cameraTarget, C3
C3D_FVec xaxis, yaxis, zaxis; C3D_FVec xaxis, yaxis, zaxis;
//Order of operations is crucial. //Order of operations is crucial.
zaxis = FVec3_Normalize(FVec3_New(cameraPosition.x - cameraTarget.x, cameraPosition.y - cameraTarget.y, cameraPosition.z - cameraTarget.z)); zaxis.x = cameraPosition.x - cameraTarget.x;
zaxis.y = cameraPosition.y - cameraTarget.y;
zaxis.z = cameraPosition.z - cameraTarget.z;
zaxis = FVec3_Normalize(zaxis);
xaxis = FVec3_Normalize(FVec3_Cross(cameraUpVector, zaxis)); xaxis = FVec3_Normalize(FVec3_Cross(cameraUpVector, zaxis));
yaxis = FVec3_Cross(zaxis, xaxis); yaxis = FVec3_Cross(zaxis, xaxis);