Added recommendations from @fincs.

This commit is contained in:
Thompson Lee 2016-09-11 17:25:16 -04:00
parent 89dcbb292e
commit bad01073bb

View File

@ -283,19 +283,6 @@ static inline void Mtx_Copy(C3D_Mtx* out, const C3D_Mtx* in)
*out = *in; *out = *in;
} }
/**
* @brief Identity matrix
* @param[out] out Matrix to fill
*/
static inline void Mtx_Identity(C3D_Mtx* out)
{
// http://www.wolframalpha.com/input/?i={{1,0,0,0},{0,1,0,0},{0,0,1,0},{0,0,0,1}}
int i;
for (i = 0; i < 16; ++i)
out->m[i] = 0.0f;
out->r[0].x = out->r[1].y = out->r[2].z = out->r[3].w = 1.0f;
}
/** /**
* @brief Multiply two matrices * @brief Multiply two matrices
* @param[out] out Output matrix * @param[out] out Output matrix
@ -520,6 +507,14 @@ static inline void Mtx_Diagonal(C3D_Mtx* out, float x, float y, float z, float w
out->r[3].w = w; out->r[3].w = w;
} }
/**
* @brief Identity matrix
* @param[out] out Matrix to fill
*/
static inline void Mtx_Identity(C3D_Mtx* out)
{
Mtx_Diagonal(out, 1.0f, 1.0f, 1.0f, 1.0f);
}
///@} ///@}
///@name Quaternion Math ///@name Quaternion Math