From 49403de54d1d5a8b246a6ff4130cd720900fb236 Mon Sep 17 00:00:00 2001 From: Thompson Lee Date: Thu, 4 Aug 2016 10:04:11 -0400 Subject: [PATCH] Addressing feedback: mtheall: The FVec3_New is redundant. --- source/maths/mtx_lookat.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/source/maths/mtx_lookat.c b/source/maths/mtx_lookat.c index 112f8a8..3244c61 100644 --- a/source/maths/mtx_lookat.c +++ b/source/maths/mtx_lookat.c @@ -8,7 +8,10 @@ void Mtx_LookAt(C3D_Mtx* out, C3D_FVec cameraPosition, C3D_FVec cameraTarget, C3 C3D_FVec xaxis, yaxis, zaxis; //Order of operations is crucial. - zaxis = FVec3_Normalize(FVec3_New(cameraPosition.x - cameraTarget.x, cameraPosition.y - cameraTarget.y, cameraPosition.z - cameraTarget.z)); + zaxis.x = cameraPosition.x - cameraTarget.x; + zaxis.y = cameraPosition.y - cameraTarget.y; + zaxis.z = cameraPosition.z - cameraTarget.z; + zaxis = FVec3_Normalize(zaxis); xaxis = FVec3_Normalize(FVec3_Cross(cameraUpVector, zaxis)); yaxis = FVec3_Cross(zaxis, xaxis);