DevKit7/libctru
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed security failure /w alignment in MemPool::Allocate().

Browse Source
This commit is contained in:
yellows8 2015-03-16 20:59:59 -04:00
parent 2fed2f4241
commit 5b5bdb1bd1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libctru/source/allocator/mem_pool.cpp
View File

@ -33,7 +33,11 @@ void MemPool::CoalesceRight(MemBlock* b)
bool MemPool::Allocate(MemChunk& chunk, u32 size, int align) bool MemPool::Allocate(MemChunk& chunk, u32 size, int align)
{ {
int alignM = (1 << align) - 1; int alignM = (1 << align) - 1;
size = (size + alignM) &~ alignM; // Round the size u32 newsize;
newsize = (size + alignM) &~ alignM; // Round the size
if(newsize < size)return false;//Return error when integer-overflow occurs due to aligning the size.
size = newsize;
// Find the first suitable block // Find the first suitable block
for (auto b = first; b; b = b->next) for (auto b = first; b; b = b->next)
{ {