DevKit7/libctru
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix decompress out-of-bounds access (#463)

Browse Source
This commit is contained in:
mtheall 2020-06-01 03:03:12 -05:00 committed by GitHub
parent 8f06d03ca6
commit 80be51e93b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libctru/source/util/decompress/decompress.c
View File

@ -229,9 +229,9 @@ iov_increment(iov_iter *it)
static inline void static inline void
iov_add(iov_iter *it, size_t size) iov_add(iov_iter *it, size_t size)
{ {
while(true) while(size > 0)
{ {
assert(it->num <= it->cnt); assert(it->num < it->cnt);
assert(it->iov[it->num].size > it->pos); assert(it->iov[it->num].size > it->pos);
if(it->iov[it->num].size - it->pos > size) if(it->iov[it->num].size - it->pos > size)
@ -244,6 +244,7 @@ iov_add(iov_iter *it, size_t size)
// advance to next buffer // advance to next buffer
size -= it->iov[it->num].size - it->pos; size -= it->iov[it->num].size - it->pos;
++it->num; ++it->num;
assert(size == 0 || it->num < it->cnt);
it->pos = 0; it->pos = 0;
} }
} }