DevKit7/libpicasso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add error message for invalid input register usage (e.g. add r0,v1,v2)

Browse Source
This commit is contained in:
fincs 2016-07-20 17:13:26 +02:00
parent d4714a5441
commit ed10f00333
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
source/picasso_assembler.cpp
View File

@ -785,6 +785,16 @@ static int parseCondExp(char* str, u32& outFlags)
return 0;
}
static inline bool isBadInputRegCombination(int a, int b)
{
return a < 0x10 && b < 0x10 && a != b;
}
static inline bool isBadInputRegCombination(int a, int b, int c)
{
return isBadInputRegCombination(a,b) || isBadInputRegCombination(b,c) || isBadInputRegCombination(c,a);
}
DEF_COMMAND(format0)
{
ENSURE_NO_MORE_ARGS();
@ -818,6 +828,9 @@ DEF_COMMAND(format1)
safe_call(ensure_valid_src_wide(rSrc2, src2Name, 2));
}
if (isBadInputRegCombination(rSrc1, rSrc2))
return throwError("source operands must be different input registers (v0..v15)\n");
int opdesc = 0;
safe_call(findOrAddOpdesc(opcode, opdesc, OPDESC_MAKE(maskFromSwizzling(rDestSw), rSrc1Sw, rSrc2Sw, 0), OPDESC_MASK_D12));
@ -903,6 +916,9 @@ DEF_COMMAND(format5)
safe_call(ensure_no_idxreg(rSrc2Idx, 2));
}
if (isBadInputRegCombination(rSrc1, rSrc2, rSrc3))
return throwError("source registers must be different input registers (v0..v15)\n");
int opdesc = 0;
safe_call(findOrAddOpdesc(opcode, opdesc, OPDESC_MAKE(maskFromSwizzling(rDestSw), rSrc1Sw, rSrc2Sw, rSrc3Sw), OPDESC_MASK_D123));