TeamHepta/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-03-20 15:51:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

tests: Fix unreachable code warnings (#14993)

Browse Source
This commit is contained in:
RaceTheMaSe
2026-02-07 18:42:59 +01:00
committed by GitHub
parent 863912aa03
commit 7c7ffb9115
7 changed files with 21 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
test/testprocess.c
View File

@@ -809,6 +809,11 @@ static int process_testNonExistingExecutable(void *arg)
static int process_testBatBadButVulnerability(void *arg)
{
#ifndef SDL_PLATFORM_WINDOWS
SDLTest_AssertPass("The BatBadBut vulnerability only applied to Windows");
return TEST_SKIPPED;
#else
TestProcessData *data = (TestProcessData *)arg;
char *inject_arg = NULL;
char **process_args = NULL;
@@ -819,10 +824,6 @@ static int process_testBatBadButVulnerability(void *arg)
SDL_IOStream *child_bat;
char buffer[256];
#ifndef SDL_PLATFORM_WINDOWS
SDLTest_AssertPass("The BatBadBut vulnerability only applied to Windows");
return TEST_SKIPPED;
#endif
/* FIXME: remove child.bat at end of loop and/or create in temporary directory */
child_bat = SDL_IOFromFile("child_batbadbut.bat", "w");
SDL_IOprintf(child_bat, "@echo off\necho Hello from child_batbadbut.bat\necho \"|bat1=%%1|\"\n");
@@ -858,6 +859,7 @@ cleanup:
SDL_free(inject_arg);
DestroyStringArray(process_args);
return TEST_COMPLETED;
#endif
}
static int process_testFileRedirection(void *arg)
@@ -970,6 +972,11 @@ cleanup:
static int process_testWindowsCmdline(void *arg)
{
#ifndef SDL_PLATFORM_WINDOWS
SDLTest_AssertPass("SDL_PROP_PROCESS_CREATE_CMDLINE_STRING only works on Windows");
return TEST_SKIPPED;
#else
TestProcessData *data = (TestProcessData *)arg;
const char *process_args[] = {
data->childprocess_path,
@@ -1012,11 +1019,6 @@ static int process_testWindowsCmdline(void *arg)
int i;
size_t total_read = 0;
#ifndef SDL_PLATFORM_WINDOWS
SDLTest_AssertPass("SDL_PROP_PROCESS_CREATE_CMDLINE_STRING only works on Windows");
return TEST_SKIPPED;
#endif
props = SDL_CreateProperties();
SDLTest_AssertCheck(props != 0, "SDL_CreateProperties()");
if (!props) {
@@ -1062,10 +1064,16 @@ static int process_testWindowsCmdline(void *arg)
failed:
SDL_DestroyProcess(process);
return TEST_ABORTED;
#endif
}
static int process_testWindowsCmdlinePrecedence(void *arg)
{
#ifndef SDL_PLATFORM_WINDOWS
SDLTest_AssertPass("SDL_PROP_PROCESS_CREATE_CMDLINE_STRING only works on Windows");
return TEST_SKIPPED;
#else
TestProcessData *data = (TestProcessData *)arg;
const char *process_args[] = {
data->childprocess_path,
@@ -1082,11 +1090,6 @@ static int process_testWindowsCmdlinePrecedence(void *arg)
int exit_code;
size_t total_read = 0;
#ifndef SDL_PLATFORM_WINDOWS
SDLTest_AssertPass("SDL_PROP_PROCESS_CREATE_CMDLINE_STRING only works on Windows");
return TEST_SKIPPED;
#endif
props = SDL_CreateProperties();
SDLTest_AssertCheck(props != 0, "SDL_CreateProperties()");
if (!props) {
@@ -1125,6 +1128,7 @@ static int process_testWindowsCmdlinePrecedence(void *arg)
failed:
SDL_DestroyProcess(process);
return TEST_ABORTED;
#endif
}
static const SDLTest_TestCaseReference processTestArguments = {