From 803cd7589a18c669421ae36f6a71c9dbba27d188 Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Thu, 12 Mar 2026 10:22:09 -0400 Subject: [PATCH] io: Remove `iodata->regular_file` check. It wasn't used, and causes an extra fstat(). --- src/io/SDL_iostream.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/io/SDL_iostream.c b/src/io/SDL_iostream.c index 8172c8e773..724617f1ad 100644 --- a/src/io/SDL_iostream.c +++ b/src/io/SDL_iostream.c @@ -488,7 +488,6 @@ typedef struct IOStreamFDData { int fd; bool autoclose; - bool regular_file; } IOStreamFDData; static int SDL_fdatasync(int fd) @@ -661,9 +660,6 @@ SDL_IOStream *SDL_IOFromFD(int fd, bool autoclose) iodata->fd = fd; iodata->autoclose = autoclose; - struct stat st; - iodata->regular_file = ((fstat(fd, &st) == 0) && S_ISREG(st.st_mode)); - SDL_IOStream *iostr = SDL_OpenIO(&iface, iodata); if (!iostr) { iface.close(iodata); @@ -686,7 +682,6 @@ typedef struct IOStreamStdioData { FILE *fp; bool autoclose; - bool regular_file; } IOStreamStdioData; #ifdef HAVE_FOPEN64 @@ -863,9 +858,6 @@ SDL_IOStream *SDL_IOFromFP(FILE *fp, bool autoclose) iodata->fp = fp; iodata->autoclose = autoclose; - struct stat st; - iodata->regular_file = ((fstat(fileno(fp), &st) == 0) && S_ISREG(st.st_mode)); - SDL_IOStream *iostr = SDL_OpenIO(&iface, iodata); if (!iostr) { iface.close(iodata);