From b028fd9604186c7a921e161d098361e3fba85441 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Fri, 29 Sep 2023 12:52:17 +0100 Subject: [PATCH] SDLTest_CompareSurfaces: Log better messages if NULL or different sizes Signed-off-by: Simon McVittie --- src/test/SDL_test_compare.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/test/SDL_test_compare.c b/src/test/SDL_test_compare.c index 023723de3b..c65b75c72a 100644 --- a/src/test/SDL_test_compare.c +++ b/src/test/SDL_test_compare.c @@ -67,12 +67,19 @@ int SDLTest_CompareSurfaces(SDL_Surface *surface, SDL_Surface *referenceSurface, char referenceFilename[FILENAME_SIZE]; /* Validate input surfaces */ - if (surface == NULL || referenceSurface == NULL) { + if (surface == NULL) { + SDLTest_LogError("Cannot compare NULL surface"); + return -1; + } + + if (referenceSurface == NULL) { + SDLTest_LogError("Cannot compare NULL reference surface"); return -1; } /* Make sure surface size is the same. */ if ((surface->w != referenceSurface->w) || (surface->h != referenceSurface->h)) { + SDLTest_LogError("Expected %dx%d surface, got %dx%d", referenceSurface->w, referenceSurface->h, surface->w, surface->h); return -2; }