mirror of
https://github.com/libsdl-org/SDL.git
synced 2026-05-02 22:30:13 +02:00
eda0261c4e
It is not uncommon for clients to redundantly set the window size and position, either as a holdover from an SDL 1 port, when this was required, due to any window state change triggering a universal update function that sets all window state, even if unnecessary (e.g. always calling SDL_SetWindowSize(), even if the window is fullscreen), or due to the use of compatability layers. Historically, these clients expect that their behavior won't override the base window state, which is an assumption that the windowing changes in SDL 3 broke by caching size and position changes that can't be applied immediately. This change drops size and position requests when the window is in the maximized and fullscreen states (fullscreen-desktop windows will be repositioned, but the non-fullscreen floating position will not be overwritten), which is behavior more in line with existing client assumptions, and should ease the porting process, as well as prevent annoying bugs when older software is run via sdl2-compat. In the process of making these changes, pending window state has been moved to separate variables in the SDL_Window struct, as this fixes bugs regarding fullscreen display selection and centering windows immediately after resize on asynchronous platforms, which had issues due to pending state possibly being overwritten.
91 lines
2.8 KiB
C
91 lines
2.8 KiB
C
/*
|
|
Simple DirectMedia Layer
|
|
Copyright (C) 1997-2024 Sam Lantinga <slouken@libsdl.org>
|
|
|
|
This software is provided 'as-is', without any express or implied
|
|
warranty. In no event will the authors be held liable for any damages
|
|
arising from the use of this software.
|
|
|
|
Permission is granted to anyone to use this software for any purpose,
|
|
including commercial applications, and to alter it and redistribute it
|
|
freely, subject to the following restrictions:
|
|
|
|
1. The origin of this software must not be misrepresented; you must not
|
|
claim that you wrote the original software. If you use this software
|
|
in a product, an acknowledgment in the product documentation would be
|
|
appreciated but is not required.
|
|
2. Altered source versions must be plainly marked as such, and must not be
|
|
misrepresented as being the original software.
|
|
3. This notice may not be removed or altered from any source distribution.
|
|
*/
|
|
#include "SDL_internal.h"
|
|
|
|
#ifdef SDL_VIDEO_DRIVER_OFFSCREEN
|
|
|
|
#include "../SDL_sysvideo.h"
|
|
#include "../../events/SDL_windowevents_c.h"
|
|
#include "../SDL_egl_c.h"
|
|
|
|
#include "SDL_offscreenwindow.h"
|
|
|
|
bool OFFSCREEN_CreateWindow(SDL_VideoDevice *_this, SDL_Window *window, SDL_PropertiesID create_props)
|
|
{
|
|
SDL_WindowData *offscreen_window = (SDL_WindowData *)SDL_calloc(1, sizeof(SDL_WindowData));
|
|
|
|
if (!offscreen_window) {
|
|
return false;
|
|
}
|
|
|
|
window->internal = offscreen_window;
|
|
|
|
if (window->x == SDL_WINDOWPOS_UNDEFINED) {
|
|
window->x = 0;
|
|
}
|
|
|
|
if (window->y == SDL_WINDOWPOS_UNDEFINED) {
|
|
window->y = 0;
|
|
}
|
|
|
|
offscreen_window->sdl_window = window;
|
|
|
|
#ifdef SDL_VIDEO_OPENGL_EGL
|
|
if (window->flags & SDL_WINDOW_OPENGL) {
|
|
|
|
if (!_this->egl_data) {
|
|
return SDL_SetError("Cannot create an OPENGL window invalid egl_data");
|
|
}
|
|
|
|
offscreen_window->egl_surface = SDL_EGL_CreateOffscreenSurface(_this, window->w, window->h);
|
|
|
|
if (offscreen_window->egl_surface == EGL_NO_SURFACE) {
|
|
return SDL_SetError("Failed to created an offscreen surface (EGL display: %p)",
|
|
_this->egl_data->egl_display);
|
|
}
|
|
} else {
|
|
offscreen_window->egl_surface = EGL_NO_SURFACE;
|
|
}
|
|
#endif // SDL_VIDEO_OPENGL_EGL
|
|
|
|
return true;
|
|
}
|
|
|
|
void OFFSCREEN_DestroyWindow(SDL_VideoDevice *_this, SDL_Window *window)
|
|
{
|
|
SDL_WindowData *offscreen_window = window->internal;
|
|
|
|
if (offscreen_window) {
|
|
#ifdef SDL_VIDEO_OPENGL_EGL
|
|
SDL_EGL_DestroySurface(_this, offscreen_window->egl_surface);
|
|
#endif
|
|
SDL_free(offscreen_window);
|
|
}
|
|
|
|
window->internal = NULL;
|
|
}
|
|
|
|
void OFFSCREEN_SetWindowSize(SDL_VideoDevice *_this, SDL_Window *window)
|
|
{
|
|
SDL_SendWindowEvent(window, SDL_EVENT_WINDOW_RESIZED, window->pending.w, window->pending.h);
|
|
}
|
|
#endif // SDL_VIDEO_DRIVER_OFFSCREEN
|