From 5b68608b4014b35d1405c459e06975f3743c705c Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Fri, 21 Oct 2022 18:54:43 +0200 Subject: [PATCH 1/3] Rename test_suite_bignum for consistency with bignum.{h,c} Align the name of the bignum test suite with the source module (which was renamed from mpi.c to bignum.c in the PolarSSL 1.x days). This also brings it into line with the test suites for the low-level bignum interfaces. Signed-off-by: Gilles Peskine --- tests/scripts/generate_bignum_tests.py | 4 ++-- tests/suites/{test_suite_mpi.data => test_suite_bignum.data} | 0 .../{test_suite_mpi.function => test_suite_bignum.function} | 0 ...te_mpi.generated.data => test_suite_bignum.generated.data} | 0 4 files changed, 2 insertions(+), 2 deletions(-) rename tests/suites/{test_suite_mpi.data => test_suite_bignum.data} (100%) rename tests/suites/{test_suite_mpi.function => test_suite_bignum.function} (100%) rename tests/suites/{test_suite_mpi.generated.data => test_suite_bignum.generated.data} (100%) diff --git a/tests/scripts/generate_bignum_tests.py b/tests/scripts/generate_bignum_tests.py index 091630decc..5cb7997af0 100755 --- a/tests/scripts/generate_bignum_tests.py +++ b/tests/scripts/generate_bignum_tests.py @@ -85,8 +85,8 @@ def combination_pairs(values: List[T]) -> List[Tuple[T, T]]: class BignumTarget(test_data_generation.BaseTarget, metaclass=ABCMeta): #pylint: disable=abstract-method - """Target for bignum (mpi) test case generation.""" - target_basename = 'test_suite_mpi.generated' + """Target for bignum (legacy) test case generation.""" + target_basename = 'test_suite_bignum.generated' class BignumOperation(BignumTarget, metaclass=ABCMeta): diff --git a/tests/suites/test_suite_mpi.data b/tests/suites/test_suite_bignum.data similarity index 100% rename from tests/suites/test_suite_mpi.data rename to tests/suites/test_suite_bignum.data diff --git a/tests/suites/test_suite_mpi.function b/tests/suites/test_suite_bignum.function similarity index 100% rename from tests/suites/test_suite_mpi.function rename to tests/suites/test_suite_bignum.function diff --git a/tests/suites/test_suite_mpi.generated.data b/tests/suites/test_suite_bignum.generated.data similarity index 100% rename from tests/suites/test_suite_mpi.generated.data rename to tests/suites/test_suite_bignum.generated.data From 618f9899541bf9510efc99a383e9102c011c0750 Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Fri, 21 Oct 2022 18:56:47 +0200 Subject: [PATCH 2/3] Don't use test_suite_mpi as an example It just got renamed, and it's also not the most canonical example since it's a somewhat deprecated interface in the development branch. Make a different module the example. Signed-off-by: Gilles Peskine --- tests/scripts/generate-afl-tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/scripts/generate-afl-tests.sh b/tests/scripts/generate-afl-tests.sh index 7c9f432ae4..a640b566dd 100755 --- a/tests/scripts/generate-afl-tests.sh +++ b/tests/scripts/generate-afl-tests.sh @@ -6,7 +6,7 @@ # # Usage: generate-afl-tests.sh # - should be the path to one of the test suite files -# such as 'test_suite_mpi.data' +# such as 'test_suite_rsa.data' # # Copyright The Mbed TLS Contributors # SPDX-License-Identifier: Apache-2.0 From d5c76cfd9f64b0fe3ee8108275ee3efa2edd522a Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Fri, 21 Oct 2022 19:00:38 +0200 Subject: [PATCH 3/3] Avoid having both test_suite_XXX.data and test_suite_XXX.*.data Although our build scripts support that, it's annoying, because it makes "test_suite_XXX" ambiguous between "all the data for test_suite_XXX.function" and "just test_suite_XXX.data". Signed-off-by: Gilles Peskine --- .../{test_suite_bignum.data => test_suite_bignum.misc.data} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tests/suites/{test_suite_bignum.data => test_suite_bignum.misc.data} (100%) diff --git a/tests/suites/test_suite_bignum.data b/tests/suites/test_suite_bignum.misc.data similarity index 100% rename from tests/suites/test_suite_bignum.data rename to tests/suites/test_suite_bignum.misc.data