TeamHepta/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2026-04-24 04:35:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

platform: fix -Wcast-align warnings in memory_buffer_alloc.c

Browse Source 
Cast from 'unsigned char *' to 'memory_header *' through an
intermediate 'void *' to suppress -Wcast-align warnings.

Some Clang-based toolchains (e.g. MetaWare/ARC) enable -Wcast-align
as part of -Wall, unlike standard Clang on x86/ARM. Combined with
-Werror this turns the casts into fatal build errors.

The casts are already alignment-safe at runtime:
- In mbedtls_memory_buffer_alloc_init(), buf is explicitly aligned
  to MBEDTLS_MEMORY_ALIGN_MULTIPLE before the cast.
- In buffer_alloc_calloc(), p is computed from an aligned base plus
  aligned offsets (sizeof(memory_header) and len are both multiples
  of MBEDTLS_MEMORY_ALIGN_MULTIPLE).
- In buffer_alloc_free(), p is derived from a previously aligned
  allocation pointer minus the aligned header size.

Signed-off-by: Mohamed Moawad <moawad@synopsys.com>
This commit is contained in:
Mohamed Moawad
2026-04-08 15:27:58 +02:00
committed by Valerio Setti
parent 4a62fdc25a
commit 827b12d459
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
library/memory_buffer_alloc.c
View File

@@ -294,7 +294,9 @@ static void *buffer_alloc_calloc(size_t n, size_t size)
}
p = ((unsigned char *) cur) + sizeof(memory_header) + len;
new = (memory_header *) p;
/* Double casting is required to prevent compilation warning on Clang-based
* compilers when "-Wcast-align" is used. */
new = (memory_header *) (void *) p;
new->size = cur->size - len - sizeof(memory_header);
new->alloc = 0;
@@ -375,7 +377,9 @@ static void buffer_alloc_free(void *ptr)
}
p -= sizeof(memory_header);
hdr = (memory_header *) p;
/* Double casting is required to prevent compilation warning on Clang-based
* compilers when "-Wcast-align" is used. */
hdr = (memory_header *) (void *) p;
if (verify_header(hdr) != 0) {
mbedtls_exit(1);
@@ -586,7 +590,9 @@ void mbedtls_memory_buffer_alloc_init(unsigned char *buf, size_t len)
heap.buf = buf;
heap.len = len;
heap.first = (memory_header *) buf;
/* Double casting is required to prevent compilation warning on Clang-based
* compilers when "-Wcast-align" is used. */
heap.first = (memory_header *) (void *) buf;
heap.first->size = len - sizeof(memory_header);
heap.first->magic1 = MAGIC1;
heap.first->magic2 = MAGIC2;