From ad6ceaa4e77d7f46d30a8044debf7c7934f9ffa9 Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Thu, 11 Dec 2025 15:55:00 +0100 Subject: [PATCH] Indicate which Clang version stops requiring the workaround Signed-off-by: Gilles Peskine --- library/aesce.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/library/aesce.c b/library/aesce.c index 2f394feb41..517ccf4a1b 100644 --- a/library/aesce.c +++ b/library/aesce.c @@ -16,15 +16,16 @@ #endif #if defined(MBEDTLS_AESCE_ARCH_IS_ARMV8_A) && !defined(__ARM_FEATURE_CRYPTO) -/* TODO: Re-consider above after https://reviews.llvm.org/D131064 merged. - * - * The intrinsic declaration are guarded by predefined ACLE macros in clang: +/* The intrinsic declaration are guarded by predefined ACLE macros in clang: * these are normally only enabled by the -march option on the command line. * By defining the macros ourselves we gain access to those declarations without * requiring -march on the command line. * * `arm_neon.h` is included by common.h, so we put these defines - * at the top of this file, before any includes. + * at the top of this file, before any includes. This is necessary with + * Clang <=15.x. With Clang 16.0 and above, these macro definitions are + * no longer required, but they're harmless. See + * https://reviews.llvm.org/D131064 */ #define __ARM_FEATURE_CRYPTO 1 /* See: https://arm-software.github.io/acle/main/acle.html#cryptographic-extensions