From bb4f58487602b18cda8713f65b1a27768404834a Mon Sep 17 00:00:00 2001 From: Valerio Setti Date: Tue, 27 Jan 2026 00:44:56 +0100 Subject: [PATCH] tests: ssl: improve test_mbedtls_tls_id_group_name_table() Check provided group_name also against the value returned from mbedtls_ssl_get_curve_name_from_tls_id(). Signed-off-by: Valerio Setti --- tests/suites/test_suite_ssl.function | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/suites/test_suite_ssl.function b/tests/suites/test_suite_ssl.function index 40f49a894b..9d2e56dd38 100644 --- a/tests/suites/test_suite_ssl.function +++ b/tests/suites/test_suite_ssl.function @@ -3599,7 +3599,6 @@ void test_mbedtls_tls_id_group_name_table(int group_id, char *group_name) mbedtls_ssl_iana_tls_group_info_t test_table[] = MBEDTLS_SSL_IANA_TLS_GROUPS_INFO; mbedtls_ssl_iana_tls_group_info_t *item; const char *table_name = NULL; - size_t table_name_len = 0; /* Ensure that the list includes at least 1 valid entry. */ TEST_ASSERT(test_table[0].tls_id != MBEDTLS_SSL_IANA_TLS_GROUP_NONE); @@ -3607,12 +3606,16 @@ void test_mbedtls_tls_id_group_name_table(int group_id, char *group_name) for (item = &test_table[0]; item->tls_id != MBEDTLS_SSL_IANA_TLS_GROUP_NONE; item++) { if (item->tls_id == group_id) { table_name = item->group_name; - table_name_len = strlen(table_name); } } TEST_ASSERT(table_name != NULL); - TEST_MEMORY_COMPARE(table_name, table_name_len, group_name, strlen(group_name)); + TEST_MEMORY_COMPARE(table_name, strlen(table_name), group_name, strlen(group_name)); + +#if defined(MBEDTLS_DEBUG_C) + const char *builtin_table_name = mbedtls_ssl_get_curve_name_from_tls_id(group_id); + TEST_MEMORY_COMPARE(builtin_table_name, strlen(builtin_table_name), group_name, strlen(group_name)); +#endif /* MBEDTLS_DEBUG_C */ exit:; }