tobid7/palladium
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

pd-ui7: Rework the Theme Api #2

New Issue
Open
opened 2025-02-28 13:13:17 +01:00 by tobid7 · 0 comments
tobid7 commented 2025-02-28 13:13:17 +01:00
Owner
Copy Link
Copy Source

Problem

Currently, the Theme Api is not using the SmartCtor Api and is linked in the UI7::Context. This makes it more difficult to simply edit some stuff

Solution

To Ensure the Access to the Theme is working as expected the Theme should be shared/linked to the Menu and DrawList
Make UI7Color a Class to accept UI7Color_ as well as u32 colors

Next

  • Take a look at the Theme class and make it public SmartCtor<Theme>
  • Rework UI7Color to a class
  • Share Theme from Context with the Menus
## **Problem** Currently, the **Theme Api** is not using the **SmartCtor Api** and is linked in the *`UI7::Context`*. This makes it more difficult to simply edit some stuff ## **Solution** To Ensure the **Access** to the **Theme** is working as expected the **Theme** should be **shared/linked** to the **Menu** and **DrawList** Make **UI7Color** a **Class** to accept **`UI7Color_`** as well as **`u32`** colors ## **Next** - Take a look at the Theme class and make it `public SmartCtor<Theme>` - Rework UI7Color to a class - Share Theme from Context with the Menus
tobid7 added the Kind/EnhancementCompat/Breaking
Priority
High
 labels 2025-02-28 13:13:17 +01:00
tobid7 self-assigned this 2025-02-28 13:13:17 +01:00
tobid7 added reference development 2025-03-06 08:37:43 +01:00
Sign in to join this conversation.
development
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels Compat/Breaking Kind/Enhancement
Priority
High
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
tobid7 (tobid7)
No Assignees tobid7
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tobid7/palladium#2