TeamHepta/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-04-29 04:47:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

atomic: Fix infinite recursion in SDL_CompilerBarrier() fallback

Browse Source 
On some platforms, SDL_MemoryBarrierRelease() is defined to
SDL_CompilerBarrier(). If SDL_CompilerBarrier() is also defined to
the fallback spinlock acquire/release, then we will infinitely
recurse in SDL_UnlockSpinlock(). Avoid this by not unlocking the
temporary spinlock we create.

(cherry picked from commit 66e98b5598)
This commit is contained in:
Cameron Gutman
2026-04-24 22:52:17 -05:00
committed by Ryan C. Gordon
parent 259e4fe1a2
commit 22b5ceb0c7
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/SDL3/SDL_atomic.h
View File

@@ -169,8 +169,9 @@ void _ReadWriteBarrier(void);
extern __inline void SDL_CompilerBarrier(void);
#pragma aux SDL_CompilerBarrier = "" parm [] modify exact [];
#else
/* We don't unlock here to avoid possible infinite recursion */
#define SDL_CompilerBarrier() \
{ SDL_SpinLock _tmp = 0; SDL_LockSpinlock(&_tmp); SDL_UnlockSpinlock(&_tmp); }
{ SDL_SpinLock _tmp = 0; SDL_LockSpinlock(&_tmp); }
#endif
/**