TeamHepta/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-04-03 15:46:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

memcpy with a NULL src/dst argument is UB

Browse Source 
malloc of UBSAN returns NULL when allocating 0 bytes, causing a call to memcpy(NULL, xxx, 0);
This commit is contained in:
Anonymous Maarten
2026-04-02 19:25:54 +02:00
committed by Anonymous Maarten
parent 501ee05129
commit 48e80c8f26
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/video/SDL_video.c
View File

@@ -1352,7 +1352,9 @@ SDL_DisplayMode **SDL_GetFullscreenDisplayModes(SDL_DisplayID displayID, int *co
result = (SDL_DisplayMode **)SDL_malloc((num_modes + 1) * sizeof(*result) + num_modes * sizeof(**result));
if (result) {
SDL_DisplayMode *modes = (SDL_DisplayMode *)((Uint8 *)result + ((num_modes + 1) * sizeof(*result)));
SDL_memcpy(modes, display->fullscreen_modes, num_modes * sizeof(*modes));
if (num_modes) {
SDL_memcpy(modes, display->fullscreen_modes, num_modes * sizeof(*modes));
}
for (i = 0; i < num_modes; ++i) {
result[i] = modes++;
}