TeamHepta/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-03-20 15:51:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

testaudio: Better fix for NULL dereference.

Browse Source 
This code already handled NULL fine, it just got wrapped in a SDL_strdup call
in e23257307e, so make that SDL_strdup check for
NULL first.
This commit is contained in:
Ryan C. Gordon
2024-06-27 17:24:49 -04:00
parent 5631c6dbaa
commit 9b8c5f642f
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/testaudio.c
View File

@@ -984,12 +984,9 @@ static Thing *CreatePhysicalDeviceThing(const SDL_AudioDeviceID which, const SDL
thing = CreateThing(recording ? THING_PHYSDEV_RECORDING : THING_PHYSDEV, next_physdev_x, 170, 5, -1, -1, physdev_texture, NULL);
if (thing) {
const char *name = SDL_GetAudioDeviceName(which);
if (!name) {
name = "[Unnamed device]";
}
thing->data.physdev.devid = which;
thing->data.physdev.recording = recording;
thing->data.physdev.name = SDL_strdup(name);
thing->data.physdev.name = name ? SDL_strdup(name) : NULL;
thing->ondrag = DeviceThing_ondrag;
thing->ondrop = PhysicalDeviceThing_ondrop;
thing->ontick = PhysicalDeviceThing_ontick;