TeamHepta/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-04-30 05:17:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

metal: Added missing lock in METAL_INTERNAL_PerformPendingDestroys.

Browse Source 
Without this lock, a concurrent call to SDL_ReleaseGPUBuffer, SDL_ReleaseGPUTransferBuffer or SDL_ReleaseGPUTexture can cause one of the arrays to be reallocated while METAL_INTERNAL_PerformPendingDestroys is iterating over it, causing a bad day all around.

(cherry picked from commit 1492911c7d)
This commit is contained in:
Jakub Wasilewski
2026-04-29 10:26:35 +02:00
committed by Sam Lantinga
parent 46f87cdc5a
commit cc150bc566
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/gpu/metal/SDL_gpu_metal.m
View File

@@ -3545,6 +3545,8 @@ static void METAL_INTERNAL_PerformPendingDestroys(
Sint32 i;
Uint32 j;
SDL_LockMutex(renderer->disposeLock);
for (i = renderer->bufferContainersToDestroyCount - 1; i >= 0; i -= 1) {
referenceCount = 0;
for (j = 0; j < renderer->bufferContainersToDestroy[i]->bufferCount; j += 1) {
@@ -3574,6 +3576,8 @@ static void METAL_INTERNAL_PerformPendingDestroys(
renderer->textureContainersToDestroyCount -= 1;
}
}
SDL_UnlockMutex(renderer->disposeLock);
}
// Fences