mirror of
https://github.com/Mbed-TLS/mbedtls.git
synced 2026-04-18 01:48:48 +02:00
Ignore test cases that TF-PSA-Crypto tells us to ignore
If the `tf-psa-crypto` submodule has `tests/scripts/analyze_outcomes.py`, require it to define a global variable `INTERNAL_TEST_CASES`. Those test cases will be ignored in Mbed TLS's coverage analysis. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This commit is contained in:
@@ -6,11 +6,28 @@ This script can also run on outcomes from a partial run, but the results are
|
||||
less likely to be useful.
|
||||
"""
|
||||
|
||||
import importlib
|
||||
import importlib.machinery
|
||||
import importlib.util
|
||||
import os
|
||||
import re
|
||||
import typing
|
||||
|
||||
import scripts_path # pylint: disable=unused-import
|
||||
from mbedtls_framework import outcome_analysis
|
||||
from mbedtls_framework import typing_util
|
||||
|
||||
|
||||
class CryptoAnalyzeOutcomesType(typing_util.Protocol):
|
||||
"""Our expectations on tf-psa-crypto/tests/scripts/analyze_outcomes.py.
|
||||
|
||||
See CoverageTask_load_crypto_module().
|
||||
"""
|
||||
#pylint: disable=too-few-public-methods
|
||||
|
||||
# Test cases that are about internal aspects of TF-PSA-Crypto,
|
||||
# which Mbed TLS is therefore not required to cover.
|
||||
INTERNAL_TEST_CASES: outcome_analysis.TestCaseSetDescription
|
||||
|
||||
|
||||
class CoverageTask(outcome_analysis.CoverageTask):
|
||||
@@ -210,6 +227,39 @@ class CoverageTask(outcome_analysis.CoverageTask):
|
||||
],
|
||||
}
|
||||
|
||||
def _load_crypto_module(self) -> None:
|
||||
"""Try to load the tf-psa-crypto submodule's outcome analysis Python module."""
|
||||
if self.crypto_module is not None:
|
||||
return
|
||||
crypto_script_path = 'tf-psa-crypto/tests/scripts/analyze_outcomes.py'
|
||||
if not os.path.exists(crypto_script_path):
|
||||
# During a transition period, while the crypto script is not
|
||||
# yet present in all branches we care about, allow it not to
|
||||
# exist.
|
||||
return
|
||||
crypto_spec = importlib.util.spec_from_file_location(
|
||||
'tf_psa_crypto.analyze_outcomes',
|
||||
crypto_script_path)
|
||||
# Assertions to help mypy.
|
||||
assert crypto_spec is not None
|
||||
assert crypto_spec.loader is not None
|
||||
self.crypto_module: typing.Optional[CryptoAnalyzeOutcomesType] = \
|
||||
importlib.util.module_from_spec(crypto_spec)
|
||||
crypto_spec.loader.exec_module(self.crypto_module)
|
||||
|
||||
def _load_crypto_instructions(self) -> None:
|
||||
"""Try to load instructions from the tf-psa-crypto submodule's outcome analysis."""
|
||||
self._load_crypto_module()
|
||||
if self.crypto_module is not None:
|
||||
crypto_internal_test_cases = self.crypto_module.INTERNAL_TEST_CASES
|
||||
self.ignored_tests.extend(crypto_internal_test_cases)
|
||||
|
||||
def __init__(self, options) -> None:
|
||||
super().__init__(options)
|
||||
self.crypto_module = None # declared with a type in _load_crypto_module above
|
||||
self._load_crypto_instructions()
|
||||
|
||||
|
||||
# List of tasks with a function that can handle this task and additional arguments if required
|
||||
KNOWN_TASKS: typing.Dict[str, typing.Type[outcome_analysis.Task]] = {
|
||||
'analyze_coverage': CoverageTask,
|
||||
|
||||
Reference in New Issue
Block a user