TeamHepta/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2026-03-20 19:21:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix record insertion

Browse Source 
We were not making enough room. We want to move everything from the
place where we are going to insert the new record.

This was not causing failures because the code does not look at the
content after the inserted record, because it correctly returns an error
when seeing the inserted record. But as a matter on principle, the test
code should be doing what it says: just insert a new record but leave
a valid fragment after it.

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
This commit is contained in:
Manuel Pégourié-Gonnard
2025-04-10 12:35:58 +02:00
parent 7af97b60e5
commit a5db6c14fd
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/suites/test_suite_ssl.function
View File

@@ -243,14 +243,14 @@ static int recombine_insert_record(mbedtls_test_ssl_buffer *buf,
TEST_LE_U(buf->content_length + 2 * header_length + inserted_content_length,
buf->capacity);
/* Make room for an empty record and a record header */
/* Make room for the inserted record and a record header for the fragment */
size_t inserted_record_start = header_length + offset;
size_t inserted_content_start = inserted_record_start + header_length;
size_t tail_record_start = inserted_content_start + inserted_content_length;
size_t tail_content_start = tail_record_start + header_length;
memmove(buf->buffer + tail_content_start,
buf->buffer + tail_record_start,
buf->content_length - tail_record_start);
buf->buffer + inserted_record_start,
buf->content_length - inserted_record_start);
buf->content_length += 2 * header_length;
/* Construct the inserted record based on the existing one */