Steven Cooreman
cfeea8fa1e
Unify driver context struct handling
...
Added zeroization of the wrapper context on failure/abort, and reliance on
the crypto core to not call an uninitialised wrapper.
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:32:50 +02:00
Steven Cooreman
150c99b884
Simplify cipher setup wrapper body
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:32:50 +02:00
Steven Cooreman
fb81aa5889
Only pass the driver-relevant portion of the context struct
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:31:58 +02:00
Steven Cooreman
5240e8b519
Style and language fixes from review
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:31:58 +02:00
Steven Cooreman
acb5a100a7
Structify cipher test driver hook variables
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:31:58 +02:00
Steven Cooreman
435beeaef3
Add new files to IDE project
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:31:58 +02:00
Steven Cooreman
a32193fae8
Add changelog entry
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:31:58 +02:00
Steven Cooreman
d53c1bf6f2
Exercise the AES-CTR multipart driver and check it gets called
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:31:58 +02:00
Steven Cooreman
8b12225717
Add a working implementation of a multipart AES-CTR test driver
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:31:58 +02:00
Steven Cooreman
3ec4018e2b
Update license texts
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:31:57 +02:00
Steven Cooreman
d3feccd3a5
Restructure cipher context object to contain driver switch
...
Once an operation has been 'accepted' by a driver, the remainder is bound
to the same driver, since driver-specific context structs cannot be shared.
This provides a pretty good gate mechanism for the fallback logic, too.
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:31:52 +02:00
Steven Cooreman
37941cb5e1
Add initial pass on a multi-part test driver
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-14 16:30:14 +02:00
Gilles Peskine
b1d3f2779b
Merge pull request #3480 from stevew817/feature/aes-ecb
...
Added support for AES-ECB to the PSA Crypto implementation
2020-09-14 14:45:14 +02:00
Gilles Peskine
a0a210fc1b
Merge pull request #3628 from gilles-peskine-arm/psa-conditional-inclusion-c-proposal
...
Pure C configuration of PSA crypto mechanisms
2020-09-12 00:33:08 +02:00
Gilles Peskine
2a739c41bd
Merge pull request #3569 from cm6n/fix_mbedtlssslsetbio_description
...
Fix typo in mbedtls_ssl_set_bio description.
2020-09-11 21:17:37 +02:00
Janos Follath
963c9e41e8
Merge pull request #3588 from guidovranken/fix-clang12-Wstring-concatenation
...
Prevent triggering Clang 12 -Wstring-concatenation warning
2020-09-11 15:27:52 +01:00
Gilles Peskine
a75a06bde6
Merge pull request #3630 from mpg/rm-useless-cast-x509
...
x509.c: Remove one unnecessary cast
2020-09-10 22:01:52 +02:00
Gilles Peskine
6bf4f5fb65
Merge pull request #3585 from jdurkop/fix/undefined-reference-3294
...
Fix the build with MBEDTLS_USE_PSA_CRYPTO without ECDSA
2020-09-10 21:59:49 +02:00
Dave Rodgman
e5874e1903
Merge pull request #3525 from HowJMay/typo
...
Fix typo in comment
2020-09-10 12:39:25 +01:00
Dave Rodgman
0e9afb8bd1
Minor fixes to changelog
...
Change section from "Bugfix" to "Changes". Minor grammar tidy-up.
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2020-09-10 08:26:39 +08:00
HowJMay
ccbd622ed7
Fix typo in comment
...
Fix typo in program/pkey/ecdh_curve25519.c
Signed-off-by: HowJMay <vulxj0j8j8@gmail.com >
2020-09-10 08:25:36 +08:00
John Durkop
d61712233e
Remove check compilation guards from travis build
...
With the increase in depends testing for PSA changes introduced
here the Travis builds are now taking too long. The check for
compilation guards will only be run on Jenkins now. See this comment
for further details.
https://github.com/ARMmbed/mbedtls/pull/3585#discussion_r485189748
Signed-off-by: John Durkop <john.durkop@fermatsoftware.com >
2020-09-09 05:18:51 -07:00
Manuel Pégourié-Gonnard
628ed4e54f
Merge pull request #3592 from d-otte/development
...
adjusting size of sliding window array to correct size.
2020-09-09 10:00:26 +02:00
John Durkop
619e09e705
Minor update to all.sh to change test order
...
Moved the new component_test_depends_pkalgs_psa to after the
component_test_depends_pkalgs test to be more consistent.
Signed-off-by: John Durkop <john.durkop@fermatsoftware.com >
2020-09-08 22:19:56 -07:00
John Durkop
d4efa8d0ac
Fix pk_ec_test_vec() to use MBEDTLS_MD_NONE
...
The pk_ec_test_vec() was incorrectly using MBEDTLS_MD_SHA1 for the
parameter to mbedtls_pk_verify(). It should use MBEDTLS_MD_NONE since
that parameter is ignored for this test case.
Signed-off-by: John Durkop <john.durkop@fermatsoftware.com >
2020-09-08 22:14:32 -07:00
John Durkop
2ec2eaac31
Fix test issues with depends-hashes
...
Needed to make additional fixes so that when MBEDTLS_USE_PSA_CRYPTO
is defined, the depends-hashes test will succeed. There are two
versions of the ecdsa_verify_wrap() function, one with
MBEDTLS_USE_PSA_CRYPTO and when when it is not enabled. The non PSA
version is not using the md_alg parameter since it is not required.
The PSA version was using that parameter to derive a different value
it needed for PSA_ALG_ECDSA. The arguement of PSA_ALG_ECDSA is
ignored for psa_sign_hash and psa_verify_hash. It is present because
it is used and must be a valid hash, not zero, for psa_sign_hash
(but not psa_verify_hash) with PSA_ALG_DETERMINISTIC_ECDSA, and it is
needed for psa_sign_message and psa_verify_message which are not
implemented yet. The local parameter now uses PSA_ALG_ECDSA_ANY for
the verify function to avoid using the md_alg parameter and avoids
returning incorrect error codes.
Fixes #3587
Signed-off-by: John Durkop <john.durkop@fermatsoftware.com >
2020-09-08 05:40:41 -07:00
Gilles Peskine
1ffec8f68f
Merge pull request #3501 from stevew817/feature/transparent_drivers_trial
...
Add partial implementation of accelerator API defined in #3493
2020-09-07 18:02:03 +02:00
Steven Cooreman
177deba54b
Fix style and pull out ECB processing in separate function
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-07 17:14:14 +02:00
Steven Cooreman
0d7c64dd8f
Changed test driver include folder to reflect it's a test driver
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-07 16:17:55 +02:00
Steven Cooreman
831c695787
Apply feedback from PR review
...
* Moved test data to .data file
* Bundled test driver hook variables in a struct
* Style fixes
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-07 14:01:52 +02:00
Daniel Otte
b9da1dd335
adding entry file to ChangeLog.d for PR3592
...
Signed-off-by: Daniel Otte <d.otte@wut.de >
2020-09-07 13:08:10 +02:00
Daniel Otte
608615168a
adjusting comment on sliding window memory usage.
...
The comment now uses '**' as exponentiation operator.
Signed-off-by: Daniel Otte <d.otte@wut.de >
2020-09-07 13:07:14 +02:00
Daniel Otte
4374dc493d
fixing spelling mistakes (window <-- windows)
...
Signed-off-by: Daniel Otte <d.otte@wut.de >
2020-09-07 13:06:40 +02:00
Gilles Peskine
34b07e7f25
Add a subsection with driver interface terminology
...
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2020-09-07 10:28:38 +02:00
Gilles Peskine
6cf4ab8f2f
Fix formatting glitch
...
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2020-09-07 09:43:16 +02:00
Gilles Peskine
853f9bd65e
Merge pull request #3625 from gilles-peskine-arm/test-fail-report-first
...
Report the first unit test failure, not the last one
2020-09-05 11:15:55 +02:00
Steven Cooreman
56250fd169
Style fixes after PR review
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:28 +02:00
Steven Cooreman
8d2bde77a1
Make sure software fallback isn't tried on opaque keys
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:28 +02:00
Steven Cooreman
15f58d2877
Move mbedtls_to_psa_error declaration to internal header
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
2c7b2f8697
Apply changes from #3546 to newly introduced files
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
f1720ea930
Fix macro naming to match inhouse style
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
1cd39d5229
Use own define for building with test drivers
...
Trying to compile in the PSA accelerator test driver under MBEDTLS_TEST_HOOKS
turned out to be awkward regarding existing builds. We'll put it under a
custom (not in config.h) define instead, since it's something that only
should happen in test.
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
7922396c25
Added changelog
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
2a1664cb49
Add & splice in test driver for ECC keygen
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
0116416e61
Expose mbedtls_error_to_psa_status for use in test drivers
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
55ae2176ab
Add and splice in signature verification through driver
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
7a2505788c
Move handling of 'SE' drivers into driver wrappers
...
This is a more natural place for handling the drivers belonging to the
'previous' SE driver spec. It makes for a cleaner psa_crypto.c, and
potentially an easier overview of how to migrate from the old SE driver
interface to the 'opaque accelerator' interface.
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
d57203d955
Add driver tests and run them through all.sh
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:27 +02:00
Steven Cooreman
cd84cb4903
Add a handcrafted first version of the driver wrapper code
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:26 +02:00
Steven Cooreman
0d59f7b092
Add configuration flag MBEDTLS_PSA_CRYPTO_DRIVERS
...
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com >
2020-09-04 14:22:26 +02:00