TeamHeptaMirrors/gcc
1
0
Fork 1
mirror of https://github.com/gcc-mirror/gcc.git synced 2026-05-06 14:59:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

builtins: Only fold abs/absu if it is sane [PR123703]

Browse Source 
To my surprise the C FE marks as builtin even a declaration which has incorrect
return type.  Normally gimple_builtin_call_types_compatible_p etc. will
just punt in cases where the return type is wrong, but builtins.cc doesn't
use that.  For e.g. the mathfn builtins like sqrt and many others, it will
punt on weird return types, but for fold_builtin_abs it doesn't and happily
tests TYPE_UNSIGNED on it and fold_convert the integral operand to it etc.,
which ICEs if the return type is aggregate.

The following patch fixes it by punting if type is not integral.

2026-01-23  Jakub Jelinek  <jakub@redhat.com>

	PR middle-end/123703
	* builtins.cc (fold_builtin_abs): Return NULL_TREE if type is not
	integral.

	* gcc.c-torture/compile/pr123703.c: New test.
This commit is contained in:
Jakub Jelinek
2026-01-23 10:37:46 +01:00
committed by Jakub Jelinek
parent e63b59a002
commit 0ba37a153f
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gcc/builtins.cc
View File

@@ -9538,7 +9538,7 @@ fold_builtin_fabs (location_t loc, tree arg, tree type)
static tree
fold_builtin_abs (location_t loc, tree arg, tree type)
{
if (!validate_arg (arg, INTEGER_TYPE))
if (!validate_arg (arg, INTEGER_TYPE) || !INTEGRAL_TYPE_P (type))
return NULL_TREE;
if (TYPE_UNSIGNED (type))

10
gcc/testsuite/gcc.c-torture/compile/pr123703.c Normal file
View File

@@ -0,0 +1,10 @@
/* PR middle-end/123703 */
struct S { int a; };
struct S abs (int);
struct S
bar (int j)
{
return abs (j);
}