TeamHeptaMirrors/gcc
1
0
Fork 1
mirror of https://github.com/gcc-mirror/gcc.git synced 2026-05-06 14:59:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

aarch64: Fix FMV reachability and cgraph_node defintion value [PR 124167]

Browse Source 
Fix the reachability checks for FMV nodes which were put in the wrong
place and fix the definition value for a dispatched symbol to match
that of the default node.

	PR target/124167

gcc/ChangeLog

	* attribs.cc (make_dispatcher_decl): Change node->definition
	to inherit from the node its called on.
	* ipa.cc (remote_unreachable_nodes): Move FMV logic out of
	(!in_boundary_p) if block.

gcc/testsuite/ChangeLog:

	* gcc.target/aarch64/pr124167.c: New test.
This commit is contained in:
Alfie Richards
2026-02-23 13:13:30 +00:00
parent bf3a264121
commit 9726eff169
3 changed files with 21 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/attribs.cc
View File

@@ -1230,7 +1230,11 @@ make_dispatcher_decl (const tree decl)
/* Set flags on the cgraph_node for the new decl. */
cgraph_node *func_node = cgraph_node::get_create (func_decl);
func_node->dispatcher_function = true;
func_node->definition = true;
/* For targets with TARGET_HAS_FMV_TARGET_ATTRIBUTE, the resolver is created
unconditionally if any versioned nodes are present.
For !TARGET_HAS_FMV_TARGET_ATTRIBUTE, the dispatcher is only defined when
the default node is defined. */
func_node->definition = node->definition || TARGET_HAS_FMV_TARGET_ATTRIBUTE;
cgraph_function_version_info *func_v
= func_node->insert_new_function_version ();

19
gcc/ipa.cc
View File

@@ -441,16 +441,6 @@ symbol_table::remove_unreachable_nodes (FILE *file)
}
}
/* A reference to the default node implies use of all the other
versions (they get used in the function resolver made later
in multiple_target.cc) */
cgraph_function_version_info *node_v = cnode->function_version ();
if (node_v && is_function_default_version (node->decl))
for (cgraph_function_version_info *fvi = node_v->next;
fvi;
fvi = fvi->next)
enqueue_node (fvi->this_node, &first, &reachable);
for (e = cnode->callees; e; e = e->next_callee)
{
symtab_node *body = e->callee->function_symbol ();
@@ -494,6 +484,15 @@ symbol_table::remove_unreachable_nodes (FILE *file)
else if (cnode->thunk)
enqueue_node (cnode->callees->callee, &first, &reachable);
/* A reference to the default node implies use of all the other
versions (they get used in the function resolver made later
in multiple_target.cc) */
cgraph_function_version_info *node_v = cnode->function_version ();
if (node_v && is_function_default_version (node->decl))
for (cgraph_function_version_info *fvi = node_v->next; fvi;
fvi = fvi->next)
enqueue_node (fvi->this_node, &first, &reachable);
/* If any reachable function has simd clones, mark them as
reachable as well. */
if (cnode->simd_clones)

7
gcc/testsuite/gcc.target/aarch64/pr124167.c Normal file
View File

@@ -0,0 +1,7 @@
/* { dg-do compile } */
/* Check there is no ICE. */
__attribute__ ((target_version ("default"))) int foo ();
int bar () { return foo (); }