TeamHeptaMirrors/gcc
1
0
Fork 1
mirror of https://github.com/gcc-mirror/gcc.git synced 2026-05-06 14:59:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

ipa: Remove LTO requirement for builtin callback carriers.

Browse Source 
Due to the if statement in ipa_compute_jump_functions_for_bb, callback
edges were never constructed for builtin functions unless LTO was
enabled.  This patch corrects this behavior, allowing GCC to optimize
callbacks more broadly.  It also extends our testing capabilities.

gcc/ChangeLog:

	* attr-callback.cc (callback_edge_callee_has_attr): New
	function.
	* attr-callback.h (callback_edge_callee_has_attr): New function
	decl.
	* ipa-prop.cc (ipa_compute_jump_functions_for_bb): Don't skip
	callback carriers when calculating jump functions.

libgomp/ChangeLog:

	* testsuite/libgomp.c/ipcp-cb-spec1.c: Remove LTO requirement.
	* testsuite/libgomp.c/ipcp-cb-spec2.c: Likewise.
	* testsuite/libgomp.c/ipcp-cb1.c: Likewise.

Signed-off-by: Josef Melcr <josef.melcr@suse.com>
This commit is contained in:
Josef Melcr
2025-11-20 23:57:57 +01:00
parent 0343c45a33
commit f9c01c47f8
6 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gcc/attr-callback.cc
View File

@@ -83,6 +83,15 @@ callback_special_case_attr (tree decl)
gcc_unreachable ();
}
/* Returns TRUE if the callee of E has a callback attribute. */
bool
callback_edge_callee_has_attr (cgraph_edge *e)
{
return lookup_attribute (CALLBACK_ATTR_IDENT,
DECL_ATTRIBUTES (e->callee->decl))
|| callback_is_special_cased (e->callee->decl, e->call_stmt);
}
/* Given an instance of callback attribute, return the 0-based
index of the called function in question. */
int

3
gcc/attr-callback.h
View File

@@ -43,6 +43,9 @@ bool callback_is_special_cased (tree decl, gcall *stmt);
/* Returns an attribute for a special cased function. */
tree callback_special_case_attr (tree decl);
/* Returns TRUE if the callee of E has a callback attribute. */
bool callback_edge_callee_has_attr (cgraph_edge *e);
/* Given an instance of callback attribute, return the 0-based
index of the called function in question. */
int callback_get_fn_index (tree cb_attr);

3
gcc/ipa-prop.cc
View File

@@ -2698,7 +2698,8 @@ ipa_compute_jump_functions_for_bb (struct ipa_func_body_info *fbi, basic_block b
/* We do not need to bother analyzing calls to unknown functions
unless they may become known during lto/whopr. */
if (!callee->definition && !flag_lto
&& !gimple_call_fnspec (cs->call_stmt).known_p ())
&& !gimple_call_fnspec (cs->call_stmt).known_p ()
&& !callback_edge_callee_has_attr (cs))
continue;
}
ipa_compute_jump_functions_for_edge (fbi, cs);

5
libgomp/testsuite/libgomp.c/ipcp-cb-spec1.c
View File

@@ -1,9 +1,8 @@
/* Test that GOMP_task is special cased when cpyfn is NULL. */
/* { dg-do run } */
/* { dg-options "-O3 -fopenmp -flto -std=gnu99 -fdump-ipa-cp-details" } */
/* { dg-options "-O3 -fopenmp -std=gnu99 -fdump-ipa-cp-details" } */
/* { dg-require-effective-target fopenmp } */
/* { dg-require-effective-target lto } */
void test(int c) {
for (int i = 0; i < c; i++)
@@ -16,4 +15,4 @@ int main() {
return 0;
}
/* { dg-final { scan-wpa-ipa-dump "Creating a specialized node of main._omp_fn" "cp" } } */
/* { dg-final { scan-ipa-dump "Creating a specialized node of main._omp_fn" "cp" } } */

3
libgomp/testsuite/libgomp.c/ipcp-cb-spec2.c
View File

@@ -2,9 +2,8 @@
NULL. */
/* { dg-do run } */
/* { dg-options "-O3 -fopenmp -flto -std=gnu99 -fdump-ipa-cp-details" } */
/* { dg-options "-O3 -fopenmp -std=gnu99 -fdump-ipa-cp-details" } */
/* { dg-require-effective-target fopenmp } */
/* { dg-require-effective-target lto } */
void test(int *a) {
for (int i = 0; i < 100; i++) {

7
libgomp/testsuite/libgomp.c/ipcp-cb1.c
View File

@@ -2,9 +2,8 @@
This tests the underlying callback attribute and its related edges. */
/* { dg-do run } */
/* { dg-options "-O3 -fopenmp -flto -std=gnu99 -fdump-ipa-cp-details" } */
/* { dg-options "-O3 -fopenmp -std=gnu99 -fdump-ipa-cp-details" } */
/* { dg-require-effective-target fopenmp } */
/* { dg-require-effective-target lto } */
int a[100];
void test(int c) {
@@ -21,5 +20,5 @@ int main() {
return a[5] - 5;
}
/* { dg-final { scan-wpa-ipa-dump "Creating a specialized node of test._omp_fn" "cp" } } */
/* { dg-final { scan-wpa-ipa-dump "Aggregate replacements: 0\\\[0]=100\\(by_ref\\)" "cp" } } */
/* { dg-final { scan-ipa-dump "Creating a specialized node of test._omp_fn" "cp" } } */
/* { dg-final { scan-ipa-dump "Aggregate replacements: 0\\\[0]=100\\(by_ref\\)" "cp" } } */